alexfh added inline comments. ================ Comment at: clang-tidy/add_new_check.py:99 @@ -97,1 +98,3 @@ + 'check_name_dashes': check_name_dashes, + 'namespace': module}) ---------------- Thinking about this once again, let's replace `namespace` with `module` for consistency.
================ Comment at: clang-tidy/add_new_check.py:103 @@ -99,3 +102,3 @@ # Adds the implementation of the new check. -def write_implementation(module_path, check_name_camel): +def write_implementation(module_path, module, check_name_camel): filename = os.path.join(module_path, check_name_camel) + '.cpp' ---------------- nit: Please remove the extra space after `module,` http://reviews.llvm.org/D15571 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
