This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf444f396863c: [clang][Interp] Implement __builtin_isfinite
(authored by tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:194
+
+ S.Stk.push>(Integral<32, true>::from(Arg.isFinite()));
+ return true;
tbaeder
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:194
+
+ S.Stk.push>(Integral<32, true>::from(Arg.isFinite()));
+ return true;
aaron.ballman wrote:
> We have platforms on which the width of an integer is not 32-bits; because
>
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:194
+
+ S.Stk.push>(Integral<32, true>::from(Arg.isFinite()));
+ return true;
We have platforms on which the width of an integer is not 32-bits; because this
is pushing val
tbaeder updated this revision to Diff 540699.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155372/new/
https://reviews.llvm.org/D155372
Files:
clang/lib/AST/Interp/InterpBuiltin.cpp
clang/test/AST/Interp/builtin-functions.cpp
Index: clang/test/AST/Interp/builtin-functions.cpp
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews
