aaron.ballman added inline comments.

================
Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:194
+
+  S.Stk.push<Integral<32, true>>(Integral<32, true>::from(Arg.isFinite()));
+  return true;
----------------
We have platforms on which the width of an integer is not 32-bits; because this 
is pushing values back onto the stack, won't we run into some odd issues where 
`builtin + 1` would be adding a 32-bit and a 16-bit value?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155372/new/

https://reviews.llvm.org/D155372

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to