[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 closed this revision. benshi001 added a comment. Closed by https://reviews.llvm.org/rG80cd505914dfc2f38f57341f9bef9d208fdc238e https://github.com/llvm/llvm-project/commit/80cd505914dfc2f38f57341f9bef9d208fdc238e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 updated this revision to Diff 545952. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/ https://reviews.llvm.org/D154588 Files: llvm/lib/Target/CSKY/CSKYISelLowering.cpp llvm/lib/Target/CSKY/CSKYInstrInfo.td llvm/test/CodeGen

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

zixuan-wu added inline comments. Comment at: llvm/test/CodeGen/CSKY/intrinsic.ll:21 +entry: + %ntz = call i32 @llvm.cttz.i32(i32 %x, i1 1) + ret i32 %ntz I think we can also test the condition that the second argument is zero. CHANGES SINCE LAST ACTION http

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 added inline comments. Comment at: llvm/test/CodeGen/CSKY/intrinsic.ll:36 +define i16 @bswap16(i16 %x) { +; CHECK-LABEL: bswap16: +; CHECK: # %bb.0: # %entry zixuan-wu wrote: > Again. It's related to cttz? I have made another patch for these addit

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 marked 2 inline comments as done. benshi001 added inline comments. Comment at: clang/test/CodeGen/CSKY/csky-builtins.c:67 + return __builtin_bswap64(x); +} zixuan-wu wrote: > Those are target-independent intrinsics/builtins. I think it's no more need

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 updated this revision to Diff 545158. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/ https://reviews.llvm.org/D154588 Files: llvm/lib/Target/CSKY/CSKYISelLowering.cpp llvm/lib/Target/CSKY/CSKYInstrInfo.td llvm/test/CodeGen/CSKY/intrinsic.ll Index: llvm/test/C

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 updated this revision to Diff 545152. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/ https://reviews.llvm.org/D154588 Files: llvm/lib/Target/CSKY/CSKYISelLowering.cpp llvm/lib/Target/CSKY/CSKYInstrInfo.td llvm/test/CodeGen

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

zixuan-wu added inline comments. Comment at: clang/test/CodeGen/CSKY/csky-builtins.c:1 +// RUN: %clang_cc1 -triple csky -emit-llvm -o - %s | FileCheck %s + benshi001 wrote: > This file is pure test, has nothing to do with `llvm.cttz`, just to avoid > another pat

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 added a comment. ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/ https://reviews.llvm.org/D154588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 added inline comments. Comment at: clang/test/CodeGen/CSKY/csky-builtins.c:1 +// RUN: %clang_cc1 -triple csky -emit-llvm -o - %s | FileCheck %s + This file is pure test, has nothing to do with `llvm.cttz`, just to avoid another patch. Repository: r

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

benshi001 updated this revision to Diff 538356. benshi001 set the repository for this revision to rG LLVM Github Monorepo. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154588/new/