This revision was automatically updated to reflect the committed changes.
Closed by commit rGf9caa12328b2: [Clang] Fix constraint checking of non-generic
lambdas. (authored by cor3ntin).
Changed prior to commit:
https://reviews.llvm.org/D154368?vs=541858&id=542806#toc
Repository:
rG LLVM Git
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some questions about comments in the test.
Comment at: clang/test/SemaTemplate/concepts.cpp:531
SingleDepthReferencesTopLambda(v);
// FIXM
cor3ntin updated this revision to Diff 541858.
cor3ntin marked 3 inline comments as done.
cor3ntin added a comment.
Address Aaron's feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154368/new/
https://reviews.llvm.org/D154368
Files:
clang/
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:4718-4719
+def note_ovl_surrogate_constraints_not_satisfied : Note<
+"candidate surrogate function %0 not viable: constraints "
+"not satisfied">;
def note_implicit_member_t
cor3ntin updated this revision to Diff 536976.
cor3ntin added a comment.
- Move the check for lambda conversion operator in CheckFunmctionConstraints so
that it is always performed.
- Add tests of constraints referring to parameters of the lambda
Repository:
rG LLVM Github Monorepo
CHANGES
cor3ntin created this revision.
Herald added a project: All.
cor3ntin requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
A lambda call operator can be a templated entity -
and therefore have constraints while not being a function template
t
