aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from some questions about comments in the test. ================ Comment at: clang/test/SemaTemplate/concepts.cpp:531 SingleDepthReferencesTopLambda(v); // FIXME: This should error on constraint failure! (Lambda!) SingleDepthReferencesTopLambda(will_fail); ---------------- Comment is now stale and can be removed? ================ Comment at: clang/test/SemaTemplate/concepts.cpp:580 ChecksLocalVar(v); // FIXME: This should error on constraint failure! (Lambda!) ChecksLocalVar(will_fail); ---------------- This one can also be removed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154368/new/ https://reviews.llvm.org/D154368 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
