[PATCH] D152946: [C++20][Modules] Implement P2615R1 revised export diagnostics.

This revision was automatically updated to reflect the committed changes. iains marked an inline comment as done. Closed by commit rGe5c7904fa0bf: [C++20][Modules] Implement P2615R1 revised export diagnostics. (authored by iains). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152946: [C++20][Modules] Implement P2615R1 revised export diagnostics.

iains marked 4 inline comments as done. iains added a comment. not sure why the debian CI is reported clang-format errors; I am not seeing them here. Comment at: clang/lib/Sema/SemaModule.cpp:824-827 + bool AllUnnamed = true; + for (auto *D : DC->decls()) +AllUnnamed &=

[PATCH] D152946: [C++20][Modules] Implement P2615R1 revised export diagnostics.

iains updated this revision to Diff 533554. iains added a comment. rebased, addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152946/new/ https://reviews.llvm.org/D152946 Files: clang/include/clang/Basic/DiagnosticSemaKind

[PATCH] D152946: [C++20][Modules] Implement P2615R1 revised export diagnostics.

shafik added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:835 + + // C++20 [module.interface]p3: if (auto *ND = dyn_cast(D)) { Can you please add the quoted text for clarity. This is especially helpful if the text changes in the future and we

[PATCH] D152946: [C++20][Modules] Implement P2615R1 revised export diagnostics.

iains added a comment. In D152946#4431974 , @h-vetinari wrote: > Mark P2615 as implemented in > https://github.com/llvm/llvm-project/blame/main/clang/www/cxx_status.html? In D152946#4431974

[PATCH] D152946: [C++20][Modules] Implement P2615R1 revised export diagnostics.

h-vetinari added a comment. Mark P2615 as implemented in https://github.com/llvm/llvm-project/blame/main/clang/www/cxx_status.html? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152946/new/ https://reviews.llvm.org

[PATCH] D152946: [C++20][Modules] Implement P2615R1 revised export diagnostics.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM with comments. Comment at: clang/lib/Sema/SemaModule.cpp:824-827 + bool AllUnnamed = true; + for (auto *D : DC->decls()) +AllUnnamed &= checkExportedDecl(S,

[PATCH] D152946: [C++20][Modules] Implement P2615R1 revised export diagnostics.

iains created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. iains added a reviewer: ChuanqiXu. iains added a subscriber: clang-modules. iains edited the summary of this revision. iains published this revision for review. iains added a comment. Herald added a proj