iains marked 4 inline comments as done. iains added a comment. not sure why the debian CI is reported clang-format errors; I am not seeing them here.
================ Comment at: clang/lib/Sema/SemaModule.cpp:824-827 + bool AllUnnamed = true; + for (auto *D : DC->decls()) + AllUnnamed &= checkExportedDecl(S, D, BlockStart); + return AllUnnamed; ---------------- ChuanqiXu wrote: > (actually I just moved this code to place it closer to the use-point). you change is more efficient, indeed, but it alters the behaviour of the diagnostics such that only the first occurrence is reported (which regresses module.interface/p5.cpp). It seems to me to be more user-friendly to report all the errors at the same time rather than one by one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152946/new/ https://reviews.llvm.org/D152946 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
