[PATCH] D152353: [NFC][Driver] Change MultilibBuilder flags argument order

2023-06-08 Thread Michael Platings via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4507dcaeafc: [NFC][Driver] Change MultilibBuilder flags argument order (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D152353: [NFC][Driver] Change MultilibBuilder flags argument order

2023-06-08 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings updated this revision to Diff 529530. michaelplatings marked an inline comment as done. michaelplatings added a comment. Negate->Disallow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152353/new/ https://reviews.llvm.org/D152353 Fi

[PATCH] D152353: [NFC][Driver] Change MultilibBuilder flags argument order

2023-06-08 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM thanks! Comment at: clang/include/clang/Driver/MultilibBuilder.h:80 + /// \p Negate defines whether the flag is negated and therefore disallowed. + MultilibBuilder &fl

[PATCH] D152353: [NFC][Driver] Change MultilibBuilder flags argument order

2023-06-07 Thread Michael Platings via Phabricator via cfe-commits
michaelplatings created this revision. michaelplatings added reviewers: phosek, simon_tatham. Herald added a subscriber: abrachet. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Follow u