[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG720e3bacbd9f: [Basic] Support 64-bit x86 target for UEFI (authored by prabhukr ). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk added a comment. Relanding the change as the build dependency issue related to the original patch is fixed by this commit: c43aa466b8980e620fd27404ca2ba60210b76111 Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 557456. Prabhuk added a comment. Relanding the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/IR/DataLayout.cpp llvm/lib/TargetParser/Tri

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk added inline comments. Comment at: llvm/unittests/IR/DataLayoutTest.cpp:109 +TEST(DataLayoutTest, UEFI) { + Triple TT = Triple("x86_64-unknown-uefi"); + mbrkusanin wrote: > Prabhuk wrote: > > mbrkusanin wrote: > > > This is giving me a linker error: > >

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

mbrkusanin added a comment. If there are others experiencing the same error then I can push my fix: https://github.com/llvm/llvm-project/pull/67696 if there are no other suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

kosarev added a comment. @Prabhuk This reproduces with my setup as well. Did you try building with `-DBUILD_SHARED_LIBS=ON`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 __

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

mbrkusanin added inline comments. Comment at: llvm/unittests/IR/DataLayoutTest.cpp:109 +TEST(DataLayoutTest, UEFI) { + Triple TT = Triple("x86_64-unknown-uefi"); + Prabhuk wrote: > mbrkusanin wrote: > > This is giving me a linker error: > > > > $ ninja unittest

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk added inline comments. Comment at: llvm/unittests/IR/DataLayoutTest.cpp:109 +TEST(DataLayoutTest, UEFI) { + Triple TT = Triple("x86_64-unknown-uefi"); + mbrkusanin wrote: > This is giving me a linker error: > > $ ninja unittests/IR/IRTests > > /us

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

mbrkusanin added inline comments. Comment at: llvm/unittests/IR/DataLayoutTest.cpp:109 +TEST(DataLayoutTest, UEFI) { + Triple TT = Triple("x86_64-unknown-uefi"); + This is giving me a linker error: $ ninja unittests/IR/IRTests /usr/bin/ld: unittests/IR/CM

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG315a407086b0: [Basic] Support 64-bit x86 target for UEFI (authored by prabhukr ). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 557263. Prabhuk added a comment. Updated the test name and added comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/IR/DataLayout.cpp llvm/l

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

MaskRay accepted this revision. MaskRay added inline comments. Comment at: llvm/unittests/IR/DataLayoutTest.cpp:108 +TEST(DataLayoutTest, TargetTripleManglingComponent) { + Triple TT = Triple("x86_64-unknown-uefi"); UEFI may be a better name in case we test mo

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 557261. Prabhuk added a comment. Add DataLayoutTest for UEFI target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/IR/DataLayout.cpp llvm/lib/Ta

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

MaskRay accepted this revision. MaskRay added a comment. DataLayout needs a unittest in llvm/unittests/IR/DataLayoutTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 ___

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 ___

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk added a comment. @phosek -- Regarding the abandoning commit. I had messed up the commit splitting process earlier. Uploaded the correct set of files for this change now. Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 557223. Prabhuk added a comment. Update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/IR/DataLayout.cpp llvm/lib/TargetParser/Triple.cpp

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 557221. Prabhuk added a comment. Datalayout update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp ll

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

phosek added a comment. Is it possible to abandon this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk marked an inline comment as done. Prabhuk added a comment. Clang Driver Changes - https://reviews.llvm.org/D159541 Current - https://reviews.llvm.org/D152206 X86 Backend changes - https://reviews.llvm.org/D159540 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 557202. Prabhuk added a comment. Splitting commit into 3 commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: llvm/lib/Target/X86/MCTargetDesc/X86MCTarge

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

phosek added a comment. Would it be possible to split up the LLVM changes into another change so we can land it separately from the Clang support? Comment at: llvm/lib/Target/X86/X86Subtarget.h:337 - bool isTargetWin64() const { return Is64Bit && isOSWindows(); } + bool is

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 557154. Prabhuk added a comment. Minor cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets/OSTarge

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 557153. Prabhuk added a comment. Update X86 backend to use Microsoft ABI for UEFI target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/Basic/Tar

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 556813. Prabhuk marked 2 inline comments as done. Prabhuk added a comment. Addressed review comments. Added "-dll" and "-tsaware:no" linker flags for UEFI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/ne

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

brad added inline comments. Comment at: clang/lib/Driver/ToolChains/UEFI.h:46 + bool HasNativeLLVMSupport() const override { return true; } + bool IsIntegratedAssemblerDefault() const override { return true; } + bool IsUnwindTablesDefault(const llvm::opt::ArgList &Args) const

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 540091. Prabhuk marked 5 inline comments as done. Prabhuk added a comment. Minor formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/li

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 540085. Prabhuk marked 6 inline comments as done. Prabhuk added a comment. Added subsystem and entry args. Improved driver test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.or

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

phosek added a comment. For comments that are already address, it's customary to mark those as "Done" to make it clear. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 ___

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/UEFI.cpp:57 + CmdArgs.push_back("-nologo"); + + if (Args.hasArg(options::OPT_g_Group, options::OPT__SLASH_Z7)) We should be also passing `-subsystem:efi_application`. Note that COFF also has

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 533809. Prabhuk added a comment. Clean up lit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets/OST

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 533795. Prabhuk added a comment. Improve lit test for uefi. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Tar

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 533782. Prabhuk added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Set the Objectformat in the appropriate place to fix the triple string for UEFI. Simplify the lit test for UEFI toolchain to C. Repository: rG

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 530917. Prabhuk added a comment. Adding a simple lit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targ

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 530609. Prabhuk added a comment. Addressed comments from last reviews except for adding lit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

phosek added a comment. This needs a lit test. Comment at: clang/lib/Driver/ToolChains/UEFI.cpp:92-97 + StringRef Linker = + Args.getLastArgValue(options::OPT_fuse_ld_EQ, CLANG_DEFAULT_LINKER); + if (Linker.empty() || Linker.equals_insensitive("lld")) +Linker = "lld-

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk updated this revision to Diff 528609. Prabhuk added a comment. Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152206/new/ https://reviews.llvm.org/D152206 Files: clang/lib/Basic/Targets.cpp clang/lib/Basic/Targets

[PATCH] D152206: [Basic] Support 64-bit x86 target for UEFI

Prabhuk created this revision. Prabhuk added a reviewer: phosek. Herald added a subscriber: pengfei. Herald added a project: All. Prabhuk requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Adding support for X86_64 UEFI target to begin