MaskRay accepted this revision.
MaskRay added inline comments.

================
Comment at: llvm/unittests/IR/DataLayoutTest.cpp:108
 
+TEST(DataLayoutTest, TargetTripleManglingComponent) {
+  Triple TT = Triple("x86_64-unknown-uefi");
----------------
UEFI may be a better name in case we test more properties in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152206/new/

https://reviews.llvm.org/D152206

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D15... Petr Hosek via Phabricator via cfe-commits
  • [PATCH] D15... Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
  • [PATCH] D15... Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
  • [PATCH] D15... Petr Hosek via Phabricator via cfe-commits
  • [PATCH] D15... Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
  • [PATCH] D15... Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
  • [PATCH] D15... Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
  • [PATCH] D15... Petr Hosek via Phabricator via cfe-commits
  • [PATCH] D15... Fangrui Song via Phabricator via cfe-commits
  • [PATCH] D15... Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
  • [PATCH] D15... Fangrui Song via Phabricator via cfe-commits
  • [PATCH] D15... Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
  • [PATCH] D15... Phabricator via cfe-commits
  • [PATCH] D15... Mirko Brkusanin via Phabricator via cfe-commits
  • [PATCH] D15... Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
  • [PATCH] D15... Mirko Brkusanin via Phabricator via cfe-commits
  • [PATCH] D15... Ivan Kosarev via Phabricator via cfe-commits
  • [PATCH] D15... Mirko Brkusanin via Phabricator via cfe-commits
  • [PATCH] D15... Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
  • [PATCH] D15... Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits
  • [PATCH] D15... Prabhu Karthikeyan Rajasekaran via Phabricator via cfe-commits

Reply via email to