[PATCH] D151634: [clang] Add test for CWG253

2023-06-25 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:1022 -namespace dr78 { // dr78: sup +namespace dr78 { // dr78: no // Under DR78, this is valid, because 'k' has static storage duration, so is shafik wrote: > Endill wrote: > > shafi

[PATCH] D151634: [clang] Add test for CWG253

2023-06-08 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:1022 -namespace dr78 { // dr78: sup +namespace dr78 { // dr78: no // Under DR78, this is valid, because 'k' has static storage duration, so is Endill wrote: > shafik wrote: > > shafi

[PATCH] D151634: [clang] Add test for CWG253

2023-06-02 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:1022 -namespace dr78 { // dr78: sup +namespace dr78 { // dr78: no // Under DR78, this is valid, because 'k' has static storage duration, so is shafik wrote: > shafik wrote: > > This

[PATCH] D151634: [clang] Add test for CWG253

2023-06-02 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:1022 -namespace dr78 { // dr78: sup +namespace dr78 { // dr78: no // Under DR78, this is valid, because 'k' has static storage duration, so is shafik wrote: > This is [issue 1380](ht

[PATCH] D151634: [clang] Add test for CWG253

2023-06-02 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill updated this revision to Diff 527804. Endill edited the summary of this revision. Endill added a comment. Mark CWG78 as superseded by 2536 Expand CWG253 test @shafik I think rather than leave 78 out, we better mark it as superseded, so that we don't forget about it. Repository: rG LLV

[PATCH] D151634: [clang] Add test for CWG253

2023-05-31 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. In D151634#4383428 , @Endill wrote: > @shafik Thank you for letting me know! Now I wonder if it was possible to > realize by myself without prior knowledge of CWG 2536, because I feel like > some cross-references are missing. > C

[PATCH] D151634: [clang] Add test for CWG253

2023-05-31 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added a comment. @shafik Thank you for letting me know! Now I wonder if it was possible to realize by myself without prior knowledge of CWG 2536, because I feel like some cross-references are missing. Can we proceed if I strip CWG 78 out, leaving only CWG 253? Repository: rG LLVM Gith

[PATCH] D151634: [clang] Add test for CWG253

2023-05-30 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added inline comments. Comment at: clang/test/CXX/drs/dr0xx.cpp:1022 -namespace dr78 { // dr78: sup +namespace dr78 { // dr78: no // Under DR78, this is valid, because 'k' has static storage duration, so is This is [issue 1380](https://github.com

[PATCH] D151634: [clang] Add test for CWG253

2023-05-28 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill updated this revision to Diff 526342. Endill added a comment. Update cxx_dr_status.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151634/new/ https://reviews.llvm.org/D151634 Files: clang/test/CXX/drs/dr0xx.cpp clang/test/CXX/drs/dr

[PATCH] D151634: [clang] Add test for CWG253

2023-05-28 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill created this revision. Endill added reviewers: clang-language-wg, shafik. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also mark CWG78 as "no". CWG253 is the only issue that references 78, and t