This revision was automatically updated to reflect the committed changes.
Closed by commit rGce8fa36e59e1: [NFC][Driver] Change Multilib flag
representation (authored by michaelplatings).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151438/new/
htt
michaelplatings updated this revision to Diff 528826.
michaelplatings added a comment.
Herald added a subscriber: ormris.
Update unit tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151438/new/
https://reviews.llvm.org/D151438
Files:
clang/i
simon_tatham accepted this revision.
simon_tatham added a comment.
This revision is now accepted and ready to land.
LGTM, but please wait at least a day for other people to have last-minute
thoughts.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D15
michaelplatings added a comment.
@phosek you made some alternative suggestions:
1. Have two separate lists of include and exclude flags.
2. Store flags as a tuple (or a struct?) of string and a tag (that is include
or exclude).
The reason for not doing that is to keep multilib selection method
michaelplatings created this revision.
michaelplatings added a reviewer: phosek.
Herald added a project: All.
michaelplatings requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay.
Herald added a project: clang.
This new representation means that if a string is a valid
