[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ec44987e54b: [clangd] Do not end inactiveRegions range at position 0 of line (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D151190?vs=528190&id=528304#toc Repository: rG LL

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks great. Comment at: clang-tools-extra/clangd/SourceCode.h:76 +/// Get the last Position on a given line. +llvm::Expected endOfLine(llvm::StringRef Code, int Line

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

nridge updated this revision to Diff 528190. nridge added a comment. Add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151190/new/ https://reviews.llvm.org/D151190 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-extra/clan

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

nridge updated this revision to Diff 528189. nridge marked 3 inline comments as done. nridge added a comment. Herald added a subscriber: mgrang. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151190/new/ https://reviews.llvm.

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

hokein added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:119 if (CollectInactiveRegions) { - ServerCallbacks->onInactiveRegionsReady( - Path, std::move(AST.getMacros().SkippedRanges)); + std::vector SkippedRanges(

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

nridge updated this revision to Diff 526409. nridge added a comment. slight simplification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151190/new/ https://reviews.llvm.org/D151190 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

nridge updated this revision to Diff 526408. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151190/new/ https://reviews.llvm.org/D151190 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tool

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

nridge planned changes to this revision. nridge added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdTests.cpp:1343 #undef CMDMACRO $inactive3[[#ifdef CMDMACRO int inactiveInt2; daiyousei-qz wrote: > hokein wrote: > > While this patch

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

daiyousei-qz added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdTests.cpp:1343 #undef CMDMACRO $inactive3[[#ifdef CMDMACRO int inactiveInt2; hokein wrote: > While this patch is an improvement, I wonder we should move it further. > >

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/ClangdTests.cpp:1343 #undef CMDMACRO $inactive3[[#ifdef CMDMACRO int inactiveInt2; While this patch is an improvement, I wonder we should move it further. Has been thinking about i

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

nridge created this revision. nridge added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. nridge requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This carries