[PATCH] D151047: [clang-format] Fix indent for selective formatting.

2023-07-18 Thread Owen Pan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0570cc568f5c: [clang-format] Fix indent for selective formatting (authored by Sedeniono, committed by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

2023-07-18 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestSelective.cpp:643-646 + Style.FixNamespaceComments = false; + Code = "namespace ns {\n" + "#define REF(alias) alias alias_var;\n" + "}"; // Format this line only Sedenio

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

2023-07-18 Thread Sedenion via Phabricator via cfe-commits
Sedeniono added inline comments. Comment at: clang/unittests/Format/FormatTestSelective.cpp:643-646 + Style.FixNamespaceComments = false; + Code = "namespace ns {\n" + "#define REF(alias) alias alias_var;\n" + "}"; // Format this line only owenp

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

2023-07-17 Thread Owen Pan via Phabricator via cfe-commits
owenpan accepted this revision. owenpan added a comment. LGTM except for D151047#4508359 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151047/new/ https://reviews.llvm.org/D151047 ___

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

2023-07-17 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestSelective.cpp:643-646 + Style.FixNamespaceComments = false; + Code = "namespace ns {\n" + "#define REF(alias) alias alias_var;\n" + "}"; // Format this line only Then I'

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

2023-07-17 Thread Sedenion via Phabricator via cfe-commits
Sedeniono updated this revision to Diff 541146. Sedeniono marked an inline comment as done. Sedeniono added a comment. Implemented review changes as suggested by @owenpan. If this is finally ok, someone please commit it to main using the following: `Sedenion <39583823+sedeni...@users.noreply.gith

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

2023-07-17 Thread Sedenion via Phabricator via cfe-commits
Sedeniono marked 6 inline comments as done. Sedeniono added inline comments. Comment at: clang/unittests/Format/FormatTestSelective.cpp:641-646 + Style = getLLVMStyle(); + Style.FixNamespaceComments = false; + Code = "namespace ns {\n" + "#define REF(alias) alias alias

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

2023-07-17 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestSelective.cpp:657 + Style = getLLVMStyle(); + + Style.IndentPPDirectives = FormatStyle::PPDirectiveIndentStyle::PPDIS_None; Comment at: clang/unittests/Format/Format

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

2023-07-15 Thread Sedenion via Phabricator via cfe-commits
Sedeniono added inline comments. Comment at: clang/unittests/Format/FormatTestSelective.cpp:664 +"#endif\n" // That this line is also formatted might be a bug. +"}};", // Dito: Bug? +format(" class Foo {\n" -

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

2023-07-15 Thread Sedenion via Phabricator via cfe-commits
Sedeniono updated this revision to Diff 540683. Sedeniono marked 4 inline comments as done. Sedeniono added a comment. Fixed typo in comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151047/new/ https://reviews.llvm.org/D151047 Files: clang

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

2023-07-15 Thread Sedenion via Phabricator via cfe-commits
Sedeniono marked 4 inline comments as done. Sedeniono added inline comments. Comment at: clang/unittests/Format/FormatTestSelective.cpp:641-646 + Style = getLLVMStyle(); + Style.FixNamespaceComments = false; + Code = "namespace ns {\n" + "#define REF(alias) alias alias

[PATCH] D151047: [clang-format] Fix indent for selective formatting.

2023-07-12 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/unittests/Format/FormatTestSelective.cpp:641-646 + Style = getLLVMStyle(); + Style.FixNamespaceComments = false; + Code = "namespace ns {\n" + "#define REF(alias) alias alias_var;\n" + "}"; + EXPECT_EQ(Code, for