[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

MaskRay added inline comments. Comment at: clang/test/Driver/arm-no-float-regs.c:23 +// HARDFLOAT: warning: '-mhard-float': selected processor lacks floating point registers +// NOWARN-NOT: selected processor lacks floating point registers For future changes lik

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings added a comment. Relanded with the warning in the "OptionIgnored" group which fixes the test failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 _

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

TWeaver added a comment. Thanks for the speedy reply and action! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings added a comment. Reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings added a comment. Thanks Tom, I'll work on it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

TWeaver added a comment. Good morning from the UK! I believe this change has caused the following buildbot to start failing: https://lab.llvm.org/buildbot/#/builders/139/builds/42214 Is anyone able to take a look? Much obliged, Tom W Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1d511e1864f1: [ARM][Driver] Warn if -mhard-float is incompatible (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. Thanks, that's much clearer. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 _

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings updated this revision to Diff 528465. michaelplatings marked an inline comment as done. michaelplatings added a comment. Restore tweak to tests to use -### to run faster. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ htt

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings marked an inline comment as done. michaelplatings added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:151 + const std::vector &Features) { + if (llvm::find(Features, "-fpregs") == Features.end()) +return; --

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings updated this revision to Diff 528461. michaelplatings added a comment. Add variable specifically for the purpose of specifying whether or not FP regs are available. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

simon_tatham added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:151 + const std::vector &Features) { + if (llvm::find(Features, "-fpregs") == Features.end()) +return; This whole patch hinges on the unspoke

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings updated this revision to Diff 524302. michaelplatings added a comment. Tweak tests to use -### to run faster. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 Files: clang/include/clang/B

[PATCH] D150902: [ARM][Driver] Warn if -mhard-float is incompatible

michaelplatings created this revision. michaelplatings added reviewers: stuij, pratlucas. Herald added subscribers: dmgreen, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang.