MaskRay added inline comments.
================ Comment at: clang/test/Driver/arm-no-float-regs.c:23 +// HARDFLOAT: warning: '-mhard-float': selected processor lacks floating point registers +// NOWARN-NOT: selected processor lacks floating point registers ---------------- For future changes like this, consider preferring `NOWARN-NOT: warning:` so that the test is slightly stricter (also assert that no other warning is emitted). I suspect that `// REQUIRES: arm-registered-target` is unneeded (test a build that removes `ARM` from `LLVM_TARGETS_TO_BUILD`) since you use `-###` for all clang invocations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150902/new/ https://reviews.llvm.org/D150902 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
