[PATCH] D150887: [clang] Convert a few tests to opaque pointers

2023-05-25 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 added a comment. In D150887#4373695 , @nikic wrote: > I wanted to check whether you plan to do more opaque pointer test conversions > in clang. Just to make sure we don't duplicate work... I'm done for now Repository: rG LLVM Github Mon

[PATCH] D150887: [clang] Convert a few tests to opaque pointers

2023-05-25 Thread Nikita Popov via Phabricator via cfe-commits
nikic added a comment. I wanted to check whether you plan to do more opaque pointer test conversions in clang. Just to make sure we don't duplicate work... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150887/new/ https://reviews.llvm.org/D150887

[PATCH] D150887: [clang] Convert a few tests to opaque pointers

2023-05-19 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 added inline comments. Comment at: clang/test/CodeGenCXX/const-init-cxx11.cpp:353 }; - // CHECK: @_ZN14VirtualMembersL13sGlobalMemoryE = internal global { i8** } { i8** getelementptr inbounds ({ [3 x i8*] }, { [3 x i8*] }* @_ZTVN14VirtualMembers12nsMemoryImplE,

[PATCH] D150887: [clang] Convert a few tests to opaque pointers

2023-05-19 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 added inline comments. Comment at: clang/test/CodeGenCXX/const-init-cxx11.cpp:353 }; - // CHECK: @_ZN14VirtualMembersL13sGlobalMemoryE = internal global { i8** } { i8** getelementptr inbounds ({ [3 x i8*] }, { [3 x i8*] }* @_ZTVN14VirtualMembers12nsMemoryImplE,

[PATCH] D150887: [clang] Convert a few tests to opaque pointers

2023-05-19 Thread Nikita Popov via Phabricator via cfe-commits
nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGenCXX/const-init-cxx11.cpp:353 }; - // CHECK: @_ZN14VirtualMembersL13sGlobalMemoryE = internal global { i8** } { i8** getelementptr inboun

[PATCH] D150887: [clang] Convert a few tests to opaque pointers

2023-05-18 Thread Sergei Barannikov via Phabricator via cfe-commits
barannikov88 added inline comments. Comment at: clang/test/CodeGenCXX/const-init-cxx11.cpp:353 }; - // CHECK: @_ZN14VirtualMembersL13sGlobalMemoryE = internal global { i8** } { i8** getelementptr inbounds ({ [3 x i8*] }, { [3 x i8*] }* @_ZTVN14VirtualMembers12nsMemoryImplE,