jansvoboda11 added a comment.
Any other feedback?
Comment at:
clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:19
#include "clang/Serialization/ASTReader.h"
+#include "clang/Tooling/DependencyScanning/DependencyScanningService.h"
#include "llvm/ADT/DenseMa
benlangmuir added inline comments.
Comment at:
clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h:69
+ /// The preprocessing mode used for scanning.
+ ScanningMode Mode;
+ /// The output format.
jansvoboda11 wrote:
> benlangmuir wrote:
jansvoboda11 added inline comments.
Comment at:
clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h:69
+ /// The preprocessing mode used for scanning.
+ ScanningMode Mode;
+ /// The output format.
benlangmuir wrote:
> Why drop `const`?
benlangmuir added inline comments.
Comment at:
clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h:69
+ /// The preprocessing mode used for scanning.
+ ScanningMode Mode;
+ /// The output format.
Why drop `const`?
Com
jansvoboda11 created this revision.
jansvoboda11 added reviewers: benlangmuir, Bigcheese.
Herald added a subscriber: ributzka.
Herald added a project: All.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Adding new field into t
