jansvoboda11 added inline comments.
================ Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h:69 + /// The preprocessing mode used for scanning. + ScanningMode Mode; + /// The output format. ---------------- benlangmuir wrote: > Why drop `const`? I don't think it adds much, since the members are private and only ever accessed in functions already marked `const`. I'm fine with keeping the `const` here if you think there's value in it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150318/new/ https://reviews.llvm.org/D150318 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
