[PATCH] D150122: [Clang] Fix status of P0960

2023-06-03 Thread Corentin Jabot via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG684f3c968d6b: [Clang] Fix status of P0960 (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150122/new/ https://reviews.llvm.org/D150122

[PATCH] D150122: [Clang] Fix status of P0960

2023-06-02 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. LGTM as well, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150122/new/ https://reviews.llvm.org/D150122 ___ cfe-commits mailing lis

[PATCH] D150122: [Clang] Fix status of P0960

2023-06-01 Thread Alan Zhao via Phabricator via cfe-commits
ayzhao accepted this revision. ayzhao added a comment. This revision is now accepted and ready to land. In D150122#4388978 , @ayzhao wrote: > In D150122#4388972 , @cor3ntin > wrote: > >> I guess we should land th

[PATCH] D150122: [Clang] Fix status of P0960

2023-06-01 Thread Alan Zhao via Phabricator via cfe-commits
ayzhao added a comment. In D150122#4388972 , @cor3ntin wrote: > I guess we should land that now @erichkeane ? Sorry, but there's actually one more crash that was just reported earlier this week: https://github.com/llvm/llvm-project/issues/63008. We shou

[PATCH] D150122: [Clang] Fix status of P0960

2023-06-01 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. I guess we should land that now @erichkeane ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150122/new/ https://reviews.llvm.org/D150122 ___ cfe-commits mailing list cfe-commits

[PATCH] D150122: [Clang] Fix status of P0960

2023-05-22 Thread Alan Zhao via Phabricator via cfe-commits
ayzhao added a subscriber: shafik. ayzhao added a comment. Status update on backports: - https://github.com/llvm/llvm-project/issues/62266 has been backported in https://github.com/llvm/llvm-project-release-prs/pull/441 - https://github.com/llvm/llvm-project/issues/61567 is still waiting on @sha

[PATCH] D150122: [Clang] Fix status of P0960

2023-05-09 Thread Alan Zhao via Phabricator via cfe-commits
ayzhao added a comment. In D150122#4329401 , @aaron.ballman wrote: > I believe we are having another release of Clang 16, but @tstellar can > confirm or deny that. > > AIUI, there were a few issues holding us back from claiming complete support > (adde

[PATCH] D150122: [Clang] Fix status of P0960

2023-05-09 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a reviewer: ayzhao. aaron.ballman added subscribers: ayzhao, tstellar. aaron.ballman added a comment. I believe we are having another release of Clang 16, but @tstellar can confirm or deny that. AIUI, there were a few issues holding us back from claiming complete support (ad

[PATCH] D150122: [Clang] Fix status of P0960

2023-05-08 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D150122#4326941 , @cor3ntin wrote: > In D150122#4326935 , @erichkeane > wrote: > >> I've got no problems with this. I'm a little suspicious of marking this >> done in clang-16 if

[PATCH] D150122: [Clang] Fix status of P0960

2023-05-08 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. In D150122#4326935 , @erichkeane wrote: > I've got no problems with this. I'm a little suspicious of marking this done > in clang-16 if this was done only at the end of the branch though? And do we > know there is going to b

[PATCH] D150122: [Clang] Fix status of P0960

2023-05-08 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. I've got no problems with this. I'm a little suspicious of marking this done in clang-16 if this was done only at the end of the branch though? And do we know there is going to be another Clang 16 release? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D150122: [Clang] Fix status of P0960

2023-05-08 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added subscribers: erichkeane, aaron.ballman. cor3ntin added a comment. @aaron.ballman @erichkeane I'll merge that later today unless you see a reason not to. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150122/new/ https://reviews.llvm.

[PATCH] D150122: [Clang] Fix status of P0960

2023-05-08 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P0960R3 and P1975R0 were marked not implemented because of #61145, This issue has been fixed and backported to LLVM 16, t