[PATCH] D149961: [Sema] Mark ineligibility of special member functions correctly

2023-05-19 Thread Roy Jacobson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0f59bee3d58f: [Sema] Mark ineligibility of special member functions correctly (authored by royjacobson). Changed prior to commit: https://reviews.llvm.org/D149961?vs=519857&id=523765#toc Repository:

[PATCH] D149961: [Sema] Mark ineligibility of special member functions correctly

2023-05-05 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Thank you for fixing this so quickly! Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:2750 + if (auto *Constructor = dyn_cast(Method)) { +if (Constructor->isDefaultConstructor() || I have look at this function a few tim

[PATCH] D149961: [Sema] Mark ineligibility of special member functions correctly

2023-05-05 Thread Roy Jacobson via Phabricator via cfe-commits
royjacobson created this revision. royjacobson added reviewers: shafik, erichkeane. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I checked if the member function declaration was a copy constructor