[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

2023-04-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D149314#4302892 , @craig.topper wrote: > Release note added in 0e02e5decc732155d8dc4b63ecccbb1477603ecd > Thanks Craig, that looks great Repositor

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

2023-04-27 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. Release note added in 0e02e5decc732155d8dc4b63ecccbb1477603ecd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149314/new/ https://reviews.llvm.org/D

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

2023-04-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D149314#4302342 , @asb wrote: > In D149314#4302312 , @reames wrote: > >> In D149314#4302300 , >> @aaron.ballman wrote: >> >>> In D149314

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

2023-04-27 Thread Alex Bradbury via Phabricator via cfe-commits
asb added a comment. In D149314#4302312 , @reames wrote: > In D149314#4302300 , @aaron.ballman > wrote: > >> In D149314#4302266 , @asb wrote: >> >>> In D149314#4302203

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

2023-04-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D149314#4302312 , @reames wrote: > In D149314#4302300 , @aaron.ballman > wrote: > >> In D149314#4302266 , @asb wrote: >> >>> In D149314#

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

2023-04-27 Thread Philip Reames via Phabricator via cfe-commits
reames added a comment. In D149314#4302300 , @aaron.ballman wrote: > In D149314#4302266 , @asb wrote: > >> In D149314#4302203 , >> @aaron.ballman wrote: >> >>> Is this a

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

2023-04-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a reviewer: erichkeane. aaron.ballman added a comment. In D149314#4302266 , @asb wrote: > In D149314#4302203 , @aaron.ballman > wrote: > >> Is this a potentially breaking change that we need t

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

2023-04-27 Thread Alex Bradbury via Phabricator via cfe-commits
asb added a comment. In D149314#4302203 , @aaron.ballman wrote: > Is this a potentially breaking change that we need to call out for users to > be aware of? We should mention this in the Clang release notes I think. Repository: rG LLVM Github Monor

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

2023-04-27 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Is this a potentially breaking change that we need to call out for users to be aware of? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149314/new/ https://reviews.llvm.org/D149314 ___

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

2023-04-27 Thread Craig Topper via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05d0caef6081: [RISCV] Remove support for attribute interrupt("user"). (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

2023-04-26 Thread Kito Cheng via Phabricator via cfe-commits
kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, let it go Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149314/new/ https://reviews.llvm.org/D149314

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

2023-04-26 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 517408. craig.topper added a comment. Add another test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149314/new/ https://reviews.llvm.org/D149314 Files: clang/include/clang/Basic/Attr.td clang/li

[PATCH] D149314: [RISCV] Remove support for attribute interrupt("user").

2023-04-26 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: jrtc27, kito-cheng. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, e