[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd7fa92126cc3: [clang] Apply -fcoverage-prefix-map reverse order (authored by gulfem). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

gulfem updated this revision to Diff 517400. gulfem added a comment. Extend the comment about the usage of CoveragePrefixMap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148757/new/ https://reviews.llvm.org/D148757 Files: clang/include/clang/B

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

gulfem added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:211 + + /// Prefix replacement map for coverage. + llvm::SmallVector, 0> CoveragePrefixMap; MaskRay wrote: > MaskRay wrote: > > While adding a comment, clarify what coverage it

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

MaskRay added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:211 + + /// Prefix replacement map for coverage. + llvm::SmallVector, 0> CoveragePrefixMap; MaskRay wrote: > While adding a comment, clarify what coverage it is? There are mul

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

gulfem updated this revision to Diff 517375. gulfem added a comment. Add text to document that coverage prefix map should be traversed in reverse order. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148757/new/ https://reviews.llvm.org/D148757 Fi

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

gulfem updated this revision to Diff 517012. gulfem marked an inline comment as done. gulfem added a comment. Added more info into HelpText and reversed prefix map in the first place to incorporate coworker feedback. GCC uses a linked list to store the prefix mappings in reverse order: https://gi

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

gulfem marked 2 inline comments as done. gulfem added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1638 : CGM(CGM), SourceInfo(SourceInfo) { - CoveragePrefixMap = CGM.getCodeGenOpts().CoveragePrefixMap; + for (const auto &[From, To] : CGM.getCodeGe

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

gulfem updated this revision to Diff 516993. gulfem added a comment. Added a comment about reverse traversal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148757/new/ https://reviews.llvm.org/D148757 Files: clang/include/clang/Basic/CodeGenOpti

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

gulfem updated this revision to Diff 516989. gulfem added a comment. Addressed feedback and rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148757/new/ https://reviews.llvm.org/D148757 Files: clang/include/clang/Basic/CodeGenOptions.h c

[PATCH] D148757: [clang] Apply -fcoverage-prefix-map reverse order

MaskRay added a comment. LGTM Comment at: clang/include/clang/Basic/CodeGenOptions.h:211 + + /// Prefix replacement map for coverage. + llvm::SmallVector, 0> CoveragePrefixMap; While adding a comment, clarify what coverage it is? There are multiple coverage