This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG78e774e0c827: [clang][Interp] Handle __extension__ unary
operators (authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D14869
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:791
+#endif
return __FUNCTION__[index];
}
aaron.ballman wrote:
> tbaeder wrote:
> > erichkeane wrote:
> > > tbaeder wrote:
> > > > It's weird that the above two statements warn
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/test/AST/Interp/literals.cpp:791
+#endif
return __FUNCTION__[index];
}
tbaeder wrote:
> erichkeane wrote:
> > tb
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148690/new/
https://reviews.llvm.org/D148690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:791
+#endif
return __FUNCTION__[index];
}
erichkeane wrote:
> tbaeder wrote:
> > It's weird that the above two statements warn about using `__FUNCTION__`
> > and the return sta
erichkeane added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:791
+#endif
return __FUNCTION__[index];
}
tbaeder wrote:
> It's weird that the above two statements warn about using `__FUNCTION__` and
> the return statement doesn't.
Aren'
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:791
+#endif
return __FUNCTION__[index];
}
It's weird that the above two statements warn about using `__FUNCTION__` and
the return statement doesn't.
Repository:
rG LLVM Git
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, tahonermann, shafik, erichkeane.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
AFAIK this is just used to suppress warnings, so ig