aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/test/AST/Interp/literals.cpp:791
+#endif
     return __FUNCTION__[index];
   }
----------------
tbaeder wrote:
> erichkeane wrote:
> > tbaeder wrote:
> > > It's weird that the above two statements warn about using `__FUNCTION__` 
> > > and the return statement doesn't.
> > Aren't they warning about it being 'unused'?  If so, the 'return' uses 
> > them...
> Right, my message wasn't clear but I meant the c++14 extension diagnostic: 
> https://godbolt.org/z/Kso8qv7jh
That is pretty strange, tbh. Might be worth investigating in a follow-up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148690/new/

https://reviews.llvm.org/D148690

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D148690: [clang][Int... Aaron Ballman via Phabricator via cfe-commits

Reply via email to