This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1e9ac717877b: [clang][Interp] Handle PredefinedExprs
(authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D148689?vs=519835&id
shafik accepted this revision.
shafik added a comment.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148689/new/
https://reviews.llvm.org/D148689
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM with a caution about testing the mangled signature (you can fix that up
when landing though).
Comment at: clang/test/AST/Interp/literals.cpp:848
+ void f
tbaeder updated this revision to Diff 519835.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148689/new/
https://reviews.llvm.org/D148689
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/ByteCodeExprGen.h
clang/test/AST/Interp/literals.cpp
Index: clang/test/AST
tbaeder updated this revision to Diff 519834.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148689/new/
https://reviews.llvm.org/D148689
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/ByteCodeExprGen.h
clang/test/AST/Interp/literals.cpp
Index: clang/test/AST
aaron.ballman added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:849
+static_assert(strings_match(__func__, "foo"));
+static_assert(strings_match(__PRETTY_FUNCTION__, "void
PredefinedExprs::foo()"));
+ }
tbaeder wrote:
> tbaeder wrote
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:849
+static_assert(strings_match(__func__, "foo"));
+static_assert(strings_match(__PRETTY_FUNCTION__, "void
PredefinedExprs::foo()"));
+ }
aaron.ballman wrote:
> You should ad
aaron.ballman added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:849
+static_assert(strings_match(__func__, "foo"));
+static_assert(strings_match(__PRETTY_FUNCTION__, "void
PredefinedExprs::foo()"));
+ }
You should add coverage for th
tbaeder updated this revision to Diff 519479.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148689/new/
https://reviews.llvm.org/D148689
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/lib/AST/Interp/ByteCodeExprGen.h
clang/test/AST/Interp/literals.cpp
Index: clang/test/AST
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:783
+
+namespace PredefinedExprs {
+ constexpr char heh(unsigned index) {
aaron.ballman wrote:
> tbaeder wrote:
> > shafik wrote:
> > > Can we add tests for each predefined expressions
aaron.ballman added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:783
+
+namespace PredefinedExprs {
+ constexpr char heh(unsigned index) {
tbaeder wrote:
> shafik wrote:
> > Can we add tests for each predefined expressions, it does not look li
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:783
+
+namespace PredefinedExprs {
+ constexpr char heh(unsigned index) {
shafik wrote:
> Can we add tests for each predefined expressions, it does not look like there
> are a lot of
shafik added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:783
+
+namespace PredefinedExprs {
+ constexpr char heh(unsigned index) {
Can we add tests for each predefined expressions, it does not look like there
are a lot of them.
Repository
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148689/new/
https://reviews.llvm.org/D148689
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, tahonermann, shafik, erichkeane.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://revi
15 matches
Mail list logo