[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

DmitryPolukhin added a comment. In D148663#4318907 , @kadircet wrote: > I agree with Ilya's concerns here. > > We deliberately don't mess with compile flags pushed over LSP. These are > "overrides" to whatever information we have from other sources, turn

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

kadircet added a comment. I agree with Ilya's concerns here. We deliberately don't mess with compile flags pushed over LSP. These are "overrides" to whatever information we have from other sources, turning on interpolation at this override layer implies we'll never fallback to other sources of

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

DmitryPolukhin added a comment. In D148663#4305202 , @ilya-biryukov wrote: > In D148663#4301589 , > @DmitryPolukhin wrote: > >> And, if they do so, this diff will just does nothing because there is an >> exact

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

ilya-biryukov added a comment. In D148663#4301589 , @DmitryPolukhin wrote: > And, if they do so, this diff will just does nothing because there is an > exact match. It starts playing only if client provided partial CDB and > inference is required. (hy

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

DmitryPolukhin added a comment. In D148663#4298496 , @ilya-biryukov wrote: > I wanted to chime in and provide a bit of context. > This was a long time ago, so I might misremember, so take this with a grain > of salt. > > Idea behind pushing the CDB over

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

ilya-biryukov added a comment. I wanted to chime in and provide a bit of context. This was a long time ago, so I might misremember, so take this with a grain of salt. Idea behind pushing the CDB over LSP was to allow the capable client to **fully** control the commands produced for the files. D

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

DmitryPolukhin added a comment. @kadircet @nridge friendly ping, could you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148663/new/ https://reviews.llvm.org/D148663 ___ cfe-commits m

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: kadircet, nridge, sammccall, ilya-biryukov. DmitryPolukhin added a project: clang-tools-extra. Herald added a subscriber: arphaman. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added a sub