DmitryPolukhin added a comment. In D148663#4318907 <https://reviews.llvm.org/D148663#4318907>, @kadircet wrote:
> I agree with Ilya's concerns here. > > We deliberately don't mess with compile flags pushed over LSP. These are > "overrides" to whatever information we have from other sources, turning on > interpolation at this override layer implies we'll never fallback to other > sources of information (as inference will always pick a target, it doesn't > have a "that's too bad" threshold). > The contract on the LSP based compile flag setting requires clients to be > "capable" of managing files somehow, having some mixed support is unlikely to > benefit other users and more likely to break things as we're changing > behaviour now (instead of fallback to underlying compilation database, we'll > have interpolation). Thank you for the feedback, I see your point. Would you mind if I make this behaviour conditionally behind a command line flag? I think most of the users never mix flags from different sources and, if they have CDB pushed from LSP, all flags except for fallback comes from this source and underlying compilation database is empty. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148663/new/ https://reviews.llvm.org/D148663 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
