[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

Unique_Usman added a comment. In D148601#4301977 , @aaron.ballman wrote: > Thank you for working on this! These changes should come with test coverage > (we have a handful of verifier tests in `clang/test/Frontend` -- you can add > a new test file ther

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

Unique_Usman added a comment. In D148601#4301977 , @aaron.ballman wrote: > Thank you for working on this! These changes should come with test coverage > (we have a handful of verifier tests in `clang/test/Frontend` -- you can add > a new test file ther

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Thank you for working on this! These changes should come with test coverage (we have a handful of verifier tests in `clang/test/Frontend` -- you can add a new test file

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

Unique_Usman added a comment. Thanks @tbaeder, I really appreciate your time. Name is Unique_Usman and my email is usmanakinyemi...@gmail.com As you mentioned, if anyone later chime in, I will be glad to update the issue back. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

tbaeder accepted this revision. tbaeder added a comment. This revision is now accepted and ready to land. When I run with `-verify=foo,bar`I only get the output for `bar-no-diagnostics`. Adding `bar-no-diagnostics`, I get no output at all and the test succeeds. I didn't know how passing multipl

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

Unique_Usman added a comment. In D148601#4295719 , @tbaeder wrote: > In D148601#4279604 , @Unique_Usman > wrote: > >> In D148601#4279334 , @tbaeder >> wrote: >> >>> I am

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

tbaeder added a comment. In D148601#4279604 , @Unique_Usman wrote: > In D148601#4279334 , @tbaeder wrote: > >> I am not 100% sure about the semantics of passing multiple prefixes, i.e. if >> the error is emitted

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

Unique_Usman updated this revision to Diff 516762. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148601/new/ https://reviews.llvm.org/D148601 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/lib/Frontend/VerifyDiagnosticConsumer.cpp Index: clang/lib/Frontend/Verify

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

Unique_Usman updated this revision to Diff 515050. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148601/new/ https://reviews.llvm.org/D148601 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/lib/Frontend/VerifyDiagnosticConsumer.cpp Index: clang/lib/Frontend/Verify

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

Unique_Usman added a comment. In D148601#4279334 , @tbaeder wrote: > I am not 100% sure about the semantics of passing multiple prefixes, i.e. if > the error is emitted for all prefixes individually or if it's only emitted if > no `expected` line for an

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

tbaeder added inline comments. Comment at: clang/lib/Frontend/VerifyDiagnosticConsumer.cpp:1097 // source file(s) processed. +const auto &Prefixes = Diags.getDiagnosticOptions().VerifyPrefixes; if (Status == HasNoDirectives) { Can move this line ins

[PATCH] D148601: [Clang] Handle Error message to output proper Prefix

tbaeder added a comment. I am not 100% sure about the semantics of passing multiple prefixes, i.e. if the error is emitted for all prefixes individually or if it's only emitted if no `expected` line for any of the prefixes is found. In the latter case we should probably add all the prefixes to