akyrtzi updated this revision to Diff 515085.
akyrtzi added a comment.
Rebase on top of `main`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148369/new/
https://reviews.llvm.org/D148369
Files:
clang/lib/Tooling/DependencyScanning/ModuleDepColle
jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.
LGTM. Note that I think we should consider renaming the `-format` flag in the
future. Ideally, it should reflect the fact that the scanner is doing different
work, not just formatt
akyrtzi added inline comments.
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:905
+ if (BriefResult) {
+llvm::outs() << "num modules: " << FD->getNumModules() << '\n';
+return HadErrors;
jansvoboda11 wrote:
> akyrtzi wrote:
> > jansvoboda11 wr
jansvoboda11 added inline comments.
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:905
+ if (BriefResult) {
+llvm::outs() << "num modules: " << FD->getNumModules() << '\n';
+return HadErrors;
akyrtzi wrote:
> jansvoboda11 wrote:
> > This assum
akyrtzi updated this revision to Diff 513828.
akyrtzi added a comment.
Remove `-optimize-args` from the test invocations since it's not relevant for
the test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148369/new/
https://reviews.llvm.org/D1483
akyrtzi updated this revision to Diff 513751.
akyrtzi added a comment.
Make sure to check `FD` is valid.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148369/new/
https://reviews.llvm.org/D148369
Files:
clang/lib/Tooling/DependencyScanning/Modul
akyrtzi added inline comments.
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:905
+ if (BriefResult) {
+llvm::outs() << "num modules: " << FD->getNumModules() << '\n';
+return HadErrors;
jansvoboda11 wrote:
> This assumes `FD` is not empty, i.
jansvoboda11 added inline comments.
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:905
+ if (BriefResult) {
+llvm::outs() << "num modules: " << FD->getNumModules() << '\n';
+return HadErrors;
This assumes `FD` is not empty, i.e. the `-format e
akyrtzi created this revision.
Herald added a project: All.
akyrtzi requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This is particularly useful to avoid diverging the modules between a PCH and a
translation-unit compilation.
Repository:
