jansvoboda11 added inline comments.
================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:905
+ if (BriefResult) {
+ llvm::outs() << "num modules: " << FD->getNumModules() << '\n';
+ return HadErrors;
----------------
This assumes `FD` is not empty, i.e. the `-format experimental-full` argument.
We should probably error out early if that's not the case.
WDYT about changing the new `-brief` flag into something like `-format
experimental-brief`? We could avoid the dependency between arguments and we'd
also make it clear the `make` and `p1689` don't have a brief variant.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148369/new/
https://reviews.llvm.org/D148369
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
