This revision was automatically updated to reflect the committed changes.
Closed by commit rGa3f688422c44: [Windows SEH] Fix ehcleanup crash for Windows
-EHa (authored by pengfei).
Changed prior to commit:
https://reviews.llvm.org/D147867?vs=511935&id=512662#toc
Repository:
rG LLVM Github Mo
pengfei added inline comments.
Comment at: clang/test/CodeGen/windows-seh-EHa-CppCatchReturn.cpp:27
+
+// FIXME: We may need to generate llvm.seh.scope.end or remove
llvm.seh.scope.begin.
+void qux() {
efriedma wrote:
> If a scope never ends because there's an "
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/test/CodeGen/windows-seh-EHa-CppCatchReturn.cpp:27
+
+// FIXME: We may need to generate llvm.seh.scope.end or remove
llvm.seh.scope.begin.
+void q
pengfei created this revision.
pengfei added reviewers: tentzen, efriedma, LuoYuanke, jyu2.
Herald added subscribers: kbarton, nemanjai.
Herald added a project: All.
pengfei requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
`Builder.GetInsert
