pengfei added inline comments.
================ Comment at: clang/test/CodeGen/windows-seh-EHa-CppCatchReturn.cpp:27 + +// FIXME: We may need to generate llvm.seh.scope.end or remove llvm.seh.scope.begin. +void qux() { ---------------- efriedma wrote: > If a scope never ends because there's an "unreachable", that's fine, I think. > The scope never dynamically ends (unless an exception is thrown). The > backend deals with the same sort of thing for other constructs with a "begin" > and "end". For example, a cleanuppad might not have a matching cleanupret. Thanks for the advice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147867/new/ https://reviews.llvm.org/D147867 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits