This revision was automatically updated to reflect the committed changes.
Closed by commit rG92f67dc27f41: [clang][Interp] Handle DiscardResult for
DeclRef- and ParenExprs (authored by tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147840/ne
shafik accepted this revision.
shafik added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147840/new/
https://reviews.llvm.org/D147840
___
cfe-commits mailing list
cfe-commits@l
tbaeder added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147840/new/
https://reviews.llvm.org/D147840
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaeder updated this revision to Diff 515660.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147840/new/
https://reviews.llvm.org/D147840
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/test/AST/Interp/literals.cpp
Index: clang/test/AST/Interp/literals.cpp
tbaeder added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:240
+return this->emitPop(*T, PE);
+ }
+
Next time this pattern shows up, I need to add a convenience function.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST AC
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, tahonermann, shafik, erichkeane.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Fixes https://github.com/llvm/llvm-project/issues
