This revision was automatically updated to reflect the committed changes.
Closed by commit rG92f67dc27f41: [clang][Interp] Handle DiscardResult for
DeclRef- and ParenExprs (authored by tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147840/new/
https://reviews.llvm.org/D147840
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/test/AST/Interp/literals.cpp
Index: clang/test/AST/Interp/literals.cpp
===================================================================
--- clang/test/AST/Interp/literals.cpp
+++ clang/test/AST/Interp/literals.cpp
@@ -814,4 +814,18 @@
return F{12}.a;
}
static_assert(ignoredDecls() == 12, "");
+
+struct A{};
+constexpr int ignoredExprs() {
+ (void)(1 / 2);
+ A a;
+ a; // expected-warning {{unused}} \
+ // ref-warning {{unused}}
+ (void)a;
+ (a); // expected-warning {{unused}} \
+ // ref-warning {{unused}}
+
+ return 0;
+}
+
#endif
Index: clang/lib/AST/Interp/ByteCodeExprGen.cpp
===================================================================
--- clang/lib/AST/Interp/ByteCodeExprGen.cpp
+++ clang/lib/AST/Interp/ByteCodeExprGen.cpp
@@ -188,7 +188,12 @@
template <class Emitter>
bool ByteCodeExprGen<Emitter>::VisitParenExpr(const ParenExpr *PE) {
- return this->visit(PE->getSubExpr());
+ const Expr *SubExpr = PE->getSubExpr();
+
+ if (DiscardResult)
+ return this->discard(SubExpr);
+
+ return this->visit(SubExpr);
}
template <class Emitter>
@@ -1872,6 +1877,9 @@
template <class Emitter>
bool ByteCodeExprGen<Emitter>::VisitDeclRefExpr(const DeclRefExpr *E) {
+ if (DiscardResult)
+ return true;
+
const auto *D = E->getDecl();
if (const auto *ECD = dyn_cast<EnumConstantDecl>(D)) {
Index: clang/test/AST/Interp/literals.cpp
===================================================================
--- clang/test/AST/Interp/literals.cpp
+++ clang/test/AST/Interp/literals.cpp
@@ -814,4 +814,18 @@
return F{12}.a;
}
static_assert(ignoredDecls() == 12, "");
+
+struct A{};
+constexpr int ignoredExprs() {
+ (void)(1 / 2);
+ A a;
+ a; // expected-warning {{unused}} \
+ // ref-warning {{unused}}
+ (void)a;
+ (a); // expected-warning {{unused}} \
+ // ref-warning {{unused}}
+
+ return 0;
+}
+
#endif
Index: clang/lib/AST/Interp/ByteCodeExprGen.cpp
===================================================================
--- clang/lib/AST/Interp/ByteCodeExprGen.cpp
+++ clang/lib/AST/Interp/ByteCodeExprGen.cpp
@@ -188,7 +188,12 @@
template <class Emitter>
bool ByteCodeExprGen<Emitter>::VisitParenExpr(const ParenExpr *PE) {
- return this->visit(PE->getSubExpr());
+ const Expr *SubExpr = PE->getSubExpr();
+
+ if (DiscardResult)
+ return this->discard(SubExpr);
+
+ return this->visit(SubExpr);
}
template <class Emitter>
@@ -1872,6 +1877,9 @@
template <class Emitter>
bool ByteCodeExprGen<Emitter>::VisitDeclRefExpr(const DeclRefExpr *E) {
+ if (DiscardResult)
+ return true;
+
const auto *D = E->getDecl();
if (const auto *ECD = dyn_cast<EnumConstantDecl>(D)) {
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
