[PATCH] D146501: [clang-format] Don't format already formatted integer literals

2023-03-26 Thread Owen Pan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b5c49ad4563: [clang-format] Don't format already formatted integer literals (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D146501: [clang-format] Don't format already formatted integer literals

2023-03-26 Thread Owen Pan via Phabricator via cfe-commits
owenpan accepted this revision. owenpan added a comment. This patch is effectively NFC. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146501/new/ https://reviews.llvm.org/D146501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D146501: [clang-format] Don't format already formatted integer literals

2023-03-22 Thread Owen Pan via Phabricator via cfe-commits
owenpan updated this revision to Diff 507622. owenpan added a comment. Simplifies the fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146501/new/ https://reviews.llvm.org/D146501 Files: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp Index: clang/lib/Format/IntegerLiteralSepar

[PATCH] D146501: [clang-format] Don't format already formatted integer literals

2023-03-22 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. In D146501#4209026 , @MyDeveloperDay wrote: > Do we have any unit tests for this that we can pump a shed load of examples > at? I would need to make `checkSeparator()` public to add unit tests for it. Even then, the tests woul

[PATCH] D146501: [clang-format] Don't format already formatted integer literals

2023-03-21 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Do we have any unit tests for this that we can pump a shed load of examples at? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146501/new/ https://reviews.llvm.org/D146501

[PATCH] D146501: [clang-format] Don't format already formatted integer literals

2023-03-21 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: MyDeveloperDay, HazardyKnusperkeks, rymiel. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes a bug in `