owenpan added a comment.

In D146501#4209026 <https://reviews.llvm.org/D146501#4209026>, @MyDeveloperDay 
wrote:

> Do we have any unit tests for this that we can pump a shed load of examples 
> at?

I would need to make `checkSeparator()` public to add unit tests for it. Even 
then, the tests would be redundant to the added assertion (`assert(Formatted != 
Text);` on line 146), which would have caught the bug.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146501/new/

https://reviews.llvm.org/D146501

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to