Pierre-vh abandoned this revision.
Pierre-vh added a comment.
https://github.com/llvm/llvm-project/pull/65715
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146023/new/
https://reviews.llvm.org/D146023
__
Pierre-vh added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146023/new/
https://reviews.llvm.org/D146023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
Pierre-vh added inline comments.
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5598
return ParseDirectiveHSAMetadata();
} else {
-if (IDVal == ".hsa_code_object_version")
cfang wrote:
> Are you sure Non-HSA does not have the four
cfang added a comment.
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5598
return ParseDirectiveHSAMetadata();
} else {
-if (IDVal == ".hsa_code_object_version")
Are you sure Non-HSA does not have the four directives you deleted
Pierre-vh added inline comments.
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5583
+ // FIXME: Shouldn't be needed anymore? Should we remove this directive
+ // entirely? See `amdpal-elf.ll` - the output ASM contains both amdgcn_target
Thi
scott.linder added inline comments.
Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:520
- assert(Func.getCallingConv() == CallingConv::AMDGPU_KERNEL ||
- Func.getCallingConv() == CallingConv::SPIR_KERNEL);
+ if (Func.getCallingConv() != CallingConv::A
Pierre-vh added inline comments.
Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:520
- assert(Func.getCallingConv() == CallingConv::AMDGPU_KERNEL ||
- Func.getCallingConv() == CallingConv::SPIR_KERNEL);
+ if (Func.getCallingConv() != CallingConv::AMDG
scott.linder added inline comments.
Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:520
- assert(Func.getCallingConv() == CallingConv::AMDGPU_KERNEL ||
- Func.getCallingConv() == CallingConv::SPIR_KERNEL);
+ if (Func.getCallingConv() != CallingConv::A
Pierre-vh added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146023/new/
https://reviews.llvm.org/D146023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
Pierre-vh removed a reviewer: jdoerfert.
Pierre-vh added a comment.
Herald added a reviewer: jdoerfert.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146023/new/
https://reviews.llvm.org/D146023
___
Pierre-vh added inline comments.
Comment at: llvm/test/MC/AMDGPU/hsa-gfx10.s:3
-// RUN: llvm-mc -filetype=obj -triple amdgcn--amdhsa -mcpu=gfx1010
--amdhsa-code-object-version=2 -mattr=-wavefrontsize32,+wavefrontsize64
-show-encoding %s | llvm-readobj -S --sd --syms - | FileChe
arsenm added a comment.
Is clover still relying on the cov2 support?
Comment at: clang/include/clang/Basic/TargetOptions.h:85
COV_None,
-COV_2 = 200,
COV_3 = 300,
I wouldn't remove the enum field, just add a comment that emission is
unsupported o
yaxunl added a comment.
LGTM on clang side.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146023/new/
https://reviews.llvm.org/D146023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://list
kzhuravl added inline comments.
Comment at: llvm/docs/AMDGPUUsage.rst:1379
.. warning::
- Code object V2 is not the default code object version emitted by
- this version of LLVM.
+ Code object V2 emission is no longer supported by this version of LLVM.
emis
14 matches
Mail list logo
