Pierre-vh added inline comments.
================
Comment at: llvm/test/MC/AMDGPU/hsa-gfx10.s:3
-// RUN: llvm-mc -filetype=obj -triple amdgcn--amdhsa -mcpu=gfx1010
--amdhsa-code-object-version=2 -mattr=-wavefrontsize32,+wavefrontsize64
-show-encoding %s | llvm-readobj -S --sd --syms - | FileCheck %s
--check-prefix=ELF
-
-// ELF: Section {
----------------
arsenm wrote:
> I thought we were still going to be able to read old objects
I think llvm-readobj uses all of the MC/Target infrastructure so if we remove
emission, we also remove reading, no?
I'm actually not sure if we plan to let readobj/readelf read COV2 object files,
it's an interesting question
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5437-5440
+ // FIXME: Metadata Verifier doesn't work with AMDPAL MD.
+ // This is a ugly workaround to avoid the verifier.
+ if (MsgPackString.find("amdpal.") == StringRef::npos) {
+ AMDGPU::HSAMD::V3::MetadataVerifier Verifier(true);
----------------
arsenm wrote:
> This looks like a separate change?
Moved to D146119
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146023/new/
https://reviews.llvm.org/D146023
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
