[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

This revision was automatically updated to reflect the committed changes. Closed by commit rG5259da75b935: [AIX][Clang] Respect -r when invoking the linker (authored by francii). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://revi

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 506577. francii added a comment. Update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

daltenty added a comment. LGTM, with a small nit about the test that should be addressed before committing Comment at: clang/test/Driver/aix-ld.c:1085 +// RUN:--sysroot %S/Inputs/aix_ppc_tree \ +// RUN:--unwindlib=libunwind \ +// RUN:-r \ ---

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 506439. francii added a comment. Allow user-specified -L and -l options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1696 if (TC.getTriple().isOSAIX()) { + if (Args.hasArg(options::OPT_r)) +break; I think this is redundant, we guard out this whole function call in the block

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

daltenty added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:237 +// Add directory to library search path. +Args.AddAllArgs(CmdArgs, options::OPT_L); +ToolChain.AddFilePathLibArgs(Args, CmdArgs); This mostly looks good, but I'm not

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 505691. francii added a comment. Add missing bracket Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/T

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 505689. francii added a comment. Add missing bracket Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/T

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 505657. francii added a comment. Herald added a subscriber: jplehr. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cp

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 505243. francii added a comment. Wildcard check for `-l`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Dri

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

w2yehia accepted this revision. w2yehia added a comment. This revision is now accepted and ready to land. LGTM. Would be nice to get @daltenty 's approval too. Comment at: clang/test/Driver/aix-ld.c:1094 +// CHECK-RELOCATABLE-NOT: "[[SYSROOT]]/usr/lib{{/|}}crti.o" +// C

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 505221. francii added a comment. Update test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/Tool

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 504884. francii added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: sstefan1, ormris. Update check in AIX.cpp, add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii added a comment. In D145899#4190055 , @w2yehia wrote: > testcase? This patch is still WIP while I verify the libraries that we intend not to add. But I will add a test case once I've done so :) Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

w2yehia added a comment. testcase? Comment at: clang/lib/Driver/ToolChains/AIX.cpp:236 + if (Args.hasArg(options::OPT_r)) { +const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath()); +C.addCommand(std::make_unique( nit: can we avoid the code du

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 504518. francii added a comment. Move `-r` check in `CommonArgs.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp cl

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker

francii updated this revision to Diff 504516. francii added a comment. Move comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145899/new/ https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChai

[PATCH] D145899: [AIX][Clang] Respect -r when invoking the linker On AIX, libraries are still being linked when `-r` is passed to the driver. This patch corrects this error.

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D145899 Files: clang/lib/Driver/ToolChains/AIX.cp