[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

kpdev42 marked an inline comment as done. kpdev42 added inline comments. Comment at: clang/lib/Driver/ToolChains/OHOS.h:38 + bool isPICDefaultForced() const override { return false; } + bool useRelaxRelocations() const override { return false; } + UnwindLibType GetUnwindLibTyp

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

MaskRay added inline comments. Herald added a subscriber: wangpc. Comment at: clang/lib/Driver/ToolChains/OHOS.h:38 + bool isPICDefaultForced() const override { return false; } + bool useRelaxRelocations() const override { return false; } + UnwindLibType GetUnwindLibType(const

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

kpdev42 added a comment. In D145227#4192628 , @DavidSpickett wrote: > Also failing on our Windows on Arm bot: > https://lab.llvm.org/buildbot/#/builders/65/builds/8607 > > I think some lines need to account for Windows slashes, `{{/|}}` should > do

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

This revision was automatically updated to reflect the committed changes. Closed by commit rG28997feb0c3a: [LLVM][OHOS] Clang toolchain and targets (authored by kpdev42). Herald added a subscriber: asb. Changed prior to commit: https://reviews.llvm.org/D145227?vs=504994&id=506511#toc Repositor

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

mysterymath added a comment. It looks like these tests don't pass when LLVM_ENABLE_LINKER_BUILD_ID is set; I've issued a revert until this can be fixed to unblock the Fuchsia toolchain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145227/new/ htt

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

mysterymath added a comment. This is also causing a breakage on the Linux and Mac Fuchsia toolchain builds: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8786633328903858561/overview Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

DavidSpickett added a comment. Also failing on our Windows on Arm bot: https://lab.llvm.org/buildbot/#/builders/65/builds/8607 I think some lines need to account for Windows slashes, `{{/|}}` should do that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

TWeaver added a comment. Good morning, I believe the two tests added in this patch, clang::ohos.c and clang::ohos.cpp are failing on the following buildbot: https://lab.llvm.org/buildbot/#/builders/216/builds/18323 is anyone able to take a look? thanks, Tom W Repository: rG LLVM Github Mo

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72474afa2757: [LLVM][OHOS] Clang toolchain and targets (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. Looks good in general. If there are some incorrect details you'll find them later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

kpdev42 updated this revision to Diff 504647. kpdev42 added a comment. Fix test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145227/new/ https://reviews.llvm.org/D145227 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Driver

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

kpdev42 updated this revision to Diff 504632. kpdev42 marked an inline comment as done. kpdev42 added a comment. Address review comments and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145227/new/ https://reviews.llvm.org/D145227 Files:

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

kpdev42 marked an inline comment as done. kpdev42 added inline comments. Comment at: clang/test/Driver/ohos.c:240 + +// CHECK-OHOS-PTHREAD-NOT: -lpthread + DavidSpickett wrote: > This one is checking that we do not link to a pthread library, because when > using

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

DavidSpickett added a comment. I'm not familiar with the details of toolchain config, but added some general comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1404 + // OHOS-specific defaults for PIC/PIE + if (Triple.isOHOSFamily()) { +switch (Triple.getAr

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

kpdev42 created this revision. kpdev42 added reviewers: DavidSpickett, echristo. kpdev42 added a project: LLVM. Herald added subscribers: yaneury, supersymetrie, Chia-hungDuan, s.egerton, ormris, cryptoad, simoncook, hiraditya, kristof.beyls. Herald added a reviewer: aaron.ballman. Herald added a