kpdev42 marked an inline comment as done.
kpdev42 added inline comments.

================
Comment at: clang/test/Driver/ohos.c:240
+
+// CHECK-OHOS-PTHREAD-NOT: -lpthread
+
----------------
DavidSpickett wrote:
> This one is checking that we do not link to a pthread library, because when 
> using musl, it already provides one?
> 
> Just checking you're not accepting the option but doing the opposite here. 
> Worth adding a comment to explain the reasoning.
Yes, musl implements pthread api, so we do not need to link with libpthread


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145227/new/

https://reviews.llvm.org/D145227

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to