This revision was automatically updated to reflect the committed changes.
Closed by commit rG9679075a1ae6: [clang][deps] NFC: Simplify worker loop
(authored by jansvoboda11).
Changed prior to commit:
https://reviews.llvm.org/D145101?vs=501616&id=501969#toc
Repository:
rG LLVM Github Monorepo
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
> I guess it was originally done this way because we have a number of
> DependencyScanning{Tool,Worker} instances
Oh of course, this makes sense. Yeah we could maybe find a differen
jansvoboda11 added inline comments.
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:802
for (unsigned I = 0; I < Pool.getThreadCount(); ++I) {
-Pool.async([I, &Lock, &Index, &Inputs, &HadErrors, &FD, &PD, &WorkerTools,
-&DependencyOS, &Errs]() {
+
benlangmuir added inline comments.
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:802
for (unsigned I = 0; I < Pool.getThreadCount(); ++I) {
-Pool.async([I, &Lock, &Index, &Inputs, &HadErrors, &FD, &PD, &WorkerTools,
-&DependencyOS, &Errs]() {
+
jansvoboda11 created this revision.
jansvoboda11 added reviewers: Bigcheese, benlangmuir.
Herald added a subscriber: ributzka.
Herald added a project: All.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch simplifies t
