benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land.
> I guess it was originally done this way because we have a number of > DependencyScanning{Tool,Worker} instances Oh of course, this makes sense. Yeah we could maybe find a different way to do it if we care, but this is a sufficiently good reason to keep doing what we're doing and shouldn't hold you up. Thanks for explaining; LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145101/new/ https://reviews.llvm.org/D145101 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits