[PATCH] D144544: [OpenMP] Improve LIT tests on composite target constructs

2023-02-22 Thread Animesh Kumar via Phabricator via cfe-commits
animeshk-amd added a comment. In D144544#4144563 , @jdoerfert wrote: > I guess this is fine. We should try to run V&V tests, this is really just > checking if we generate (some) code. Thanks for accepting. Right. By running V&V tests, do you mean to su

[PATCH] D144544: [OpenMP] Improve LIT tests on composite target constructs

2023-02-22 Thread Animesh Kumar via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG265ea1c7459d: [OpenMP] Improve LIT tests on composite target constructs (authored by animeshk-amd). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D144544: [OpenMP] Improve LIT tests on composite target constructs

2023-02-22 Thread Animesh Kumar via Phabricator via cfe-commits
animeshk-amd updated this revision to Diff 499513. animeshk-amd added a comment. Removed a pragma line which was not required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144544/new/ https://reviews.llvm.org/D144544 Files: clang/test/OpenMP/ta

[PATCH] D144544: [OpenMP] Improve LIT tests on composite target constructs

2023-02-22 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. I guess this is fine. We should try to run V&V tests, this is really just checking if we generate (some) code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D144544: [OpenMP] Improve LIT tests on composite target constructs

2023-02-22 Thread Animesh Kumar via Phabricator via cfe-commits
animeshk-amd created this revision. animeshk-amd added reviewers: saiislam, JonChesterfield. Herald added subscribers: guansong, yaxunl. Herald added a project: All. animeshk-amd requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1.