animeshk-amd added a comment. In D144544#4144563 <https://reviews.llvm.org/D144544#4144563>, @jdoerfert wrote:
> I guess this is fine. We should try to run V&V tests, this is really just > checking if we generate (some) code. Thanks for accepting. Right. By running V&V tests, do you mean to suggest that these combinations of directives should instead be tested using execution tests which are usually run using `ninja check-openmp` ? For example, tests in the "openmp/libomptarget/test/" directory. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144544/new/ https://reviews.llvm.org/D144544 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
