[PATCH] D143725: [llvm-objdump][ARM] support --symbolize-operands for ARM/ELF

jhenderson added inline comments. Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1145 + // So far only supports ARM/Thumb, PowerPC and X86. + Triple triple = STI->getTargetTriple(); + if (!triple.isPPC() && !triple.isX86() && !triple.isARM() && covanam w

[PATCH] D143725: [llvm-objdump][ARM] support --symbolize-operands for ARM/ELF

covanam added a comment. In D143725#4127923 , @Esme wrote: > Please include as much context as possible with your diff. > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Thank you. Will read that and will add more contex

[PATCH] D143725: [llvm-objdump][ARM] support --symbolize-operands for ARM/ELF

Esme added a comment. Please include as much context as possible with your diff. https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1145 + // So far only supports ARM/Thumb, PowerPC and X86. +

[PATCH] D143725: [llvm-objdump][ARM] support --symbolize-operands for ARM/ELF

hoy added inline comments. Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1169-1171 + // On PowerPC and ARM/Thumb, if the address of a branch is the same as + // the target, it means that it's a function call. Do not mark the label + // for this case. ---

[PATCH] D143725: [llvm-objdump][ARM] support --symbolize-operands for ARM/ELF

covanam created this revision. covanam added reviewers: shchenz, rlavaee, jhenderson, hoyFB, MaskRay, llvm-commits, cfe-commits. Herald added subscribers: kristof.beyls, emaste. Herald added a project: All. covanam requested review of this revision. Herald added a project: LLVM. Support --symboli