Esme added a comment. Please include as much context as possible with your diff. https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
================ Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1145 + // So far only supports ARM/Thumb, PowerPC and X86. + Triple triple = STI->getTargetTriple(); + if (!triple.isPPC() && !triple.isX86() && !triple.isARM() && ---------------- Please capitalize the first letter of variable names. ================ Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1172 + // for this case. + bool isFunctionCall = + Target == Index && ---------------- ditto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143725/new/ https://reviews.llvm.org/D143725 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
