This revision was automatically updated to reflect the committed changes.
Closed by commit rL31: [DWARF] Allow forward declarations of a class
template instantiation (authored by probinson).
Changed prior to commit:
https://reviews.llvm.org/D14358?vs=116862&id=117030#toc
Repository:
rL L
probinson added a comment.
I think I will go ahead and commit this; it doesn't change the status quo for
CodeView and if something is warranted we can do that in a follow-up.
https://reviews.llvm.org/D14358
___
cfe-commits mailing list
cfe-commits@
On Wed, Sep 27, 2017 at 1:58 PM Paul Robinson via Phabricator <
revi...@reviews.llvm.org> wrote:
> probinson added a reviewer: rnk.
> probinson added a comment.
>
> +rnk for the CodeView question.
>
>
>
>
> Comment at: include/clang/Frontend/CodeGenOptions.def:222
>
probinson added a reviewer: rnk.
probinson added a comment.
+rnk for the CodeView question.
Comment at: include/clang/Frontend/CodeGenOptions.def:222
///< of inline stack frames without .dwo
files.
+CODEGENOPT(DebugFwdTemplateParams, 1, 0)
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks OK to me - couple of minor questions.
Comment at: include/clang/Frontend/CodeGenOptions.def:222
///< of inline stack frames wit
(though perhaps we had some position that debugger tuning wouldn't ever be the
only way to access functionality, only change defaults)
That's correct. Tuning must unpack to other settings that can be set
separately. That was very strong feedback from when we introduced the tuning
concept.
--p
probinson updated this revision to Diff 116862.
probinson added a comment.
command-line option is cc1 not driver
internal flag moved from LangOpts to CodeGenOpts and renamed
simplified test
https://reviews.llvm.org/D14358
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/Code
On Wed, Sep 27, 2017 at 11:50 AM Paul Robinson via Phabricator <
revi...@reviews.llvm.org> wrote:
> probinson added a comment.
>
> In https://reviews.llvm.org/D14358#882445, @dblaikie wrote:
>
> > > I would prefer to eliminate the `` from the instance name as
> well, because our debugger reconstru
probinson added a comment.
In https://reviews.llvm.org/D14358#882445, @dblaikie wrote:
> > I would prefer to eliminate the `` from the instance name as well,
> > because our debugger reconstructs a name more to its liking from the
> > parameter children. However, IIUC the name with params is u
dblaikie added a comment.
> I would prefer to eliminate the `` from the instance name as well,
> because our debugger reconstructs a name more to its liking from the
> parameter children. However, IIUC the name with params is used for
> deduplication in LTO, so that is probably not such a good
probinson added a comment.
In https://reviews.llvm.org/D14358#881666, @aprantl wrote:
> Does this have to be exposed through the driver or could this be a cc1 option
> only?
My thinking was to make it easier for LLDB to play with it and decide whether
DWARF conformance on this point is a good
aprantl added a comment.
Does this have to be exposed through the driver or could this be a cc1 option
only?
Comment at: include/clang/Basic/LangOptions.def:144
BENIGN_LANGOPT(EmitAllDecls , 1, 0, "emitting all declarations")
+BENIGN_LANGOPT(EmitFwdTemplateChildren, 1, 0
probinson updated this revision to Diff 116711.
probinson added a comment.
Add a command-line flag to control emitting the template parameter children.
Default to on for SCE debugger tuning.
I am not super excited about my choice of option name or the help text;
alternate suggestions welcome.
I
I'm roughly where I was before, I think:
"In any case, it seems like it might make sense for you to upstream your
template naming change and put it under the PS4 debugger tuning option, and
put this change there too, once the motivation for it is in-tree. At that
point, while I'd be curious about
probinson updated this revision to Diff 106063.
probinson added a comment.
Refresh to current TOT, and ping. Funny what you can find in a year-old to-do
list
https://reviews.llvm.org/D14358
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGenCXX/debug-info-template-fwd-param.cpp
test/Mod
On Wed, Dec 9, 2015 at 12:46 PM, Robinson, Paul <
paul_robin...@playstation.sony.com> wrote:
> | Types are a bit more vague (as to whether omitting unreferenced types is
> supported by the standard) DWARF 4 just says "Structure, union, and class
> types are represented by debugging information ent
| Types are a bit more vague (as to whether omitting unreferenced types is
supported by the standard) DWARF 4 just says "Structure, union, and class types
are represented by debugging information entries ...".
There's some expansion of the "permissive" discussion in the works for DWARF 5.
In e
> *From:* David Blaikie [mailto:dblai...@gmail.com]
> *Sent:* Wednesday, December 09, 2015 11:28 AM
>
> *To:* Robinson, Paul
> *Cc:* Marshall, Peter; llvm-dev; cfe-commits (cfe-commits@lists.llvm.org)
> *Subject:* Re: [PATCH] D14358: DWARF's forward decl of a template should
Blaikie [mailto:dblai...@gmail.com]
Sent: Wednesday, December 09, 2015 11:28 AM
To: Robinson, Paul
Cc: Marshall, Peter; llvm-dev; cfe-commits (cfe-commits@lists.llvm.org)
Subject: Re: [PATCH] D14358: DWARF's forward decl of a template should have
template parameters.
On Wed, Dec 9, 2015 a
se on "correctness" of DWARF). If there's some practical
> problem/use case it'd be useful to understand it so we make sure we're
> fixing it the right way.
>
> - Dave
>
>
>
> --paulr
>
>
>
> *From:* David Blaikie [mailto:dblai...@gmail
paulr
From: David Blaikie [mailto:dblai...@gmail.com]
Sent: Wednesday, December 09, 2015 10:49 AM
To: Robinson, Paul
Cc: Marshall, Peter; llvm-dev; cfe-commits (cfe-commits@lists.llvm.org)
Subject: Re: [PATCH] D14358: DWARF's forward decl of a template should have
template parameters.
On
>
> From:"Robinson, Paul"
> To:David Blaikie , "Marshall, Peter" <
> peter_marsh...@sn.scee.net>
> Cc:"reviews+d14358+public+d3104135076f0...@reviews.llvm.org"
>,
> "cfe-commits (cfe-commits@lists.llvm.org)"
d the features that you'd like to build with
this info that can't be built without it (as a minimum: features that GDB
doesn't support, since any features GDB does support seem to be implementable
with the current info Clang and GCC emit)
- David
Thanks,
--paulr
From: David Bla
;
>
>
> *From:* David Blaikie [mailto:dblai...@gmail.com]
> *Sent:* Monday, November 09, 2015 4:08 PM
>
> *To:* Robinson, Paul
> *Cc:* reviews+d14358+public+d3104135076f0...@reviews.llvm.org;
> cfe-commits (cfe-commits@lists.llvm.org)
> *Subject:* Re: [PATCH] D14358: DWAR
ublic+d3104135076f0...@reviews.llvm.org; cfe-commits
(cfe-commits@lists.llvm.org)
Subject: Re: [PATCH] D14358: DWARF's forward decl of a template should have
template parameters.
On Mon, Nov 9, 2015 at 3:55 PM, Robinson, Paul
mailto:paul_robin...@playstation.sony.com>>
wrote:
| Why is
CC emit)
- David
>
>
> Thanks,
>
> --paulr
>
>
>
> *From:* David Blaikie [mailto:dblai...@gmail.com]
> *Sent:* Monday, November 09, 2015 1:46 PM
>
> *To:* Robinson, Paul
> *Cc:* reviews+d14358+public+d3104135076f0...@reviews.llvm.org;
> cfe-commits (cf
lto:dblai...@gmail.com<mailto:dblai...@gmail.com>]
Sent: Wednesday, November 04, 2015 8:30 PM
To:
reviews+d14358+public+d3104135076f0...@reviews.llvm.org<mailto:reviews%2bd14358%2bpublic%2bd3104135076f0...@reviews.llvm.org>;
Robinson, Paul
Subject: Re: [PATCH] D14358: DWARF's forward
dblai...@gmail.com]
> *Sent:* Thursday, November 05, 2015 12:10 AM
> *To:* Robinson, Paul
> *Cc:* reviews+d14358+public+d3104135076f0...@reviews.llvm.org;
> cfe-commits (cfe-commits@lists.llvm.org)
>
> *Subject:* Re: [PATCH] D14358: DWARF's forward decl of a template should
probinson added a comment.
Building a debug clang before and after this change and comparing the sum of
.debug_* sizes, shows just a shade under 1% increase.
http://reviews.llvm.org/D14358
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
id Blaikie [mailto:dblai...@gmail.com]
Sent: Thursday, November 05, 2015 12:10 AM
To: Robinson, Paul
Cc: reviews+d14358+public+d3104135076f0...@reviews.llvm.org; cfe-commits
(cfe-commits@lists.llvm.org)
Subject: Re: [PATCH] D14358: DWARF's forward decl of a template should have
template parameters.
es (& other
non-globally scoped types) in a way that more closely models the source by
emitting a declaration where they were declared, and a definition where
they are defined (with the usual DW_AT_specification to wire them up)
>
>
> *From:* David Blaikie [mailto:dblai...@gmail.com
To: reviews+d14358+public+d3104135076f0...@reviews.llvm.org; Robinson, Paul
Subject: Re: [PATCH] D14358: DWARF's forward decl of a template should have
template parameters.
On Wed, Nov 4, 2015 at 5:53 PM, Paul Robinson via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
pro
probinson added a comment.
GCC 4.8.4 on Linux doesn't produce these, but DWARF 4 section 5.5.8 says a
class template instantiation is just like the equivalent non-template class
entry, with the exception of the template parameter entries. I read that as
meaning an incomplete description (i.e.
aprantl added a comment.
Unless this is some kind of optimization that we specifically added to minimize
debug info size (I have never looked at our template support in detail), this
looks totally reasonable. Do other compilers do the same here?
http://reviews.llvm.org/D14358
__
probinson added a comment.
In debug-info-template-member.cpp, some things came out in a different order;
that's the only change there.
http://reviews.llvm.org/D14358
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
probinson created this revision.
probinson added reviewers: echristo, dblaikie, aprantl.
probinson added a subscriber: cfe-commits.
We were forgetting the template parameters on the forward declaration of a
template class.
http://reviews.llvm.org/D14358
Files:
lib/CodeGen/CGDebugInfo.cpp
t
36 matches
Mail list logo
